Skip to content

Conversation

@ganey
Copy link

@ganey ganey commented Jun 22, 2025

I've been experiencing the GOAWAY error, it comes in spikes and affects thousands of our users.

We run roughly 9 cloudflared, with 4gb ram, 4cpu each, lowest traffic is around 60 requests/s per cloudflared. We find these GOAWAY errors in the logs when we noticed a huge spike in 524 errors to our users.

Builds on top of this PR #1274

Fixes #1273

Allows http2 requests to be retried only when a GOAWAY frame is received.

GOAWAY spec: https://datatracker.ietf.org/doc/html/rfc7540#section-6.8
How GetBody is handled: https://github.com/golang/net/blob/master/http2/transport.go#L664

@diogotorres97
Copy link

ping @ganey

@ganey
Copy link
Author

ganey commented Jul 18, 2025

ping @ganey

hey, what do you need from me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 GOAWAY frames not handled correctly with http2

3 participants